[Select] Implement WAI-ARIA dropdown without label #16739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
accessibility
eps1lon
commented
Jul 24, 2019
| @@ -264,11 +265,11 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) { | |||
| )} | |||
| ref={displayRef} | |||
| data-mui-test="SelectDisplay" | |||
| aria-pressed={open ? 'true' : 'false'} | |||
There was a problem hiding this comment.
aria-pressed is for toggle buttons:
aria-pressed="false" | a | Identifies the button as a toggle button.Indicates the toggle button is not pressed.
aria-pressed="true" | a | Identifies the button as a toggle button.Indicates the toggle button is pressed.
-- https://www.w3.org/TR/wai-aria-practices/examples/button/button.html
eps1lon
force-pushed
the
fix/Select/wai-aria
branch
from
6bffe39 to
1b0a7ef
Compare
Details of bundle changes.Comparing: 4d8206d...1b0a7ef
|
|
Does the change solve any of the open accessibility issues with the Select component? |
oliviertassinari
approved these changes
Jul 24, 2019
2 tasks
Good point. Should improve what screen reader announces by removing the misleading |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #16409
Implements https://www.w3.org/TR/wai-aria-practices/examples/listbox/listbox-collapsible.html
Labeling logic isn't included since this requires a broader scope. I think this might be fully implementable within the
TextField. Maybe with a separate component. Shouldn't block this change though.