Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Create separate workspace #16638

Closed
wants to merge 11 commits into from
Closed

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 18, 2019

BREAKING

- yarn workspace docs typescript:formatted
+ yarn workspace docs typescript:transpile

- yarn docs:typescript
+ yarn workspace docs typescript:transpile:dev

- yarn docs:typescript:check
+ yarn workspace docs typescript

- yarn docs:typescript:formatted
+ yarn workspace docs typescript:transpile

This will be a long living branch that's heavily rebased.

I've reached the point where the clashes between library and app have reached a level for me personally that warrants a refactor. This will be disrupting, it will hurt github blame but I'd hope we have a more focused repo in the end.

This is just a refactor so don't expect immediate features. The features this will enable are:

  • focused CI/CD installs reducing install times for certain jobs (currently buggy in yarn v1)
  • reduced top level scripts with yarn v2 (current script entries in package.json will become obsolete)

Refactoring improvements:

  • reduce top level directories by 2
  • separate dependencies (whats lib dev vs whats app code?)
  • docs related "stuff" lives closer together
  • clearer distinction between lib and app transpilation (next.js technically didn't allow the current way of setting presets)

I hope that the new layout will make it easier to debug why we can't esmodules in our docs.

Test plan:

  • scripts

    • api
    • buld
    • build-sw
    • deploy
    • dev
    • export
    • icons
    • size-why
    • start
    • i18n
    • typescript
    • typescript:check
    • typescript:formatted
  • successful deploys over time

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Jul 18, 2019
@eps1lon eps1lon mentioned this pull request Jul 18, 2019
15 tasks
@eps1lon
Copy link
Member Author

eps1lon commented Jul 18, 2019

Closing in favor of #16640

Azure didn't pick this up as well.

@eps1lon eps1lon closed this Jul 18, 2019
@eps1lon eps1lon deleted the docs/workspace branch July 18, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant