Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Migrate ClockPointer to emotion #26057

Merged
merged 12 commits into from
May 13, 2021
Merged

[pickers] Migrate ClockPointer to emotion #26057

merged 12 commits into from
May 13, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp
Copy link
Member Author

siriwatknp commented Apr 29, 2021 •
edited
Loading

@eps1lon @mnajdova This component is react class so I cannot use useThemeProps because react hook cannot use inside class. Should the component change to functional component?

Decide not to change in this PR, it is an internal component.

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 29, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 00f829d

@siriwatknp siriwatknp mentioned this pull request Apr 29, 2021
Closed
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate ClockPointer to emotion [pickers] Migrate ClockPointer to emotion Apr 29, 2021
@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Apr 29, 2021
@github-actions github-actions bot mentioned this pull request May 2, 2021
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 5, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 10, 2021
@siriwatknp siriwatknp requested a review from mnajdova May 10, 2021 13:18
@siriwatknp siriwatknp requested a review from mnajdova May 12, 2021 08:25
@siriwatknp siriwatknp merged commit 3aa6bf4 into mui:next May 13, 2021
@siriwatknp siriwatknp deleted the clock-pointer-emotion branch May 13, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-pr-bot @mnajdova @oliviertassinari