[docs-infra] Add icon to callouts #38525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
design
|
The
|
danilo-leal
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Very happy with this one! Thanks for kicking it off @alexfauquette 🙏
| ['info', 'success', 'warning', 'error'].includes(token.severity) | ||
| ? [ | ||
| '<svg focusable="false" aria-hidden="true" viewBox="0 0 24 24" data-testid="ContentCopyRoundedIcon">', | ||
| `<use class="MuiCode-copied-icon" xlink:href="#${token.severity}-icon" />`, |
There was a problem hiding this comment.
Now on any page, these SVG get loaded. This can't be tree-shaked. e.g. view-source:https://master--material-ui.netlify.app/blog/mui-x-mid-v6-features/.
I wonder what's best. Per https://cloudfour.com/thinks/svg-icon-stress-test/, we could use inline SVG, it doesn't see much different than the symbol sprite for performance, so maybe better.
|
There are a few duplicated icons, e.g. 
#38689 created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38519
This PR adds icons to the documentation callouts! We also took advantage of the opportunity to clean instances of it that were using emojis instead of the built-in icons. There might be more spread out throughout the docs ⎯ it was just a quick check.
https://deploy-preview-38525--material-ui.netlify.app/experiments/docs/callouts/
To-dos:
<symbols/>ids are already correct)