[material-ui][docs] Correct Google font CDN URL as Roboto 600 weight is not used #40852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
|
Looks like a regression from #38398. Now, while this is a good step, it's not enough to solve the problem. |
oliviertassinari
added
regression
danilo-leal
changed the title
|
Thanks for raising this @xuhdev ! As @oliviertassinari noted, this change alone isn't enough to close out the problem—you'll need to comb through the examples found in #38398 and remove all links to the |
xuhdev
changed the title
|
THanks for the reminder! I updated the URL elsewhere. Please note that the |
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
changed the title
The 600 in the URL doesn't seem to do anything and material UI does not use 600 any way. Remove it from the recommended CDN URL. Signed-off-by: Hong Xu <[email protected]>
oliviertassinari
force-pushed
the
patch-1
branch
from
7a474ff to
a6eb8e0
Compare
|
Rebased on HEAD |
oliviertassinari
approved these changes
Feb 3, 2024
oliviertassinari
added a commit
that referenced
this pull request
Feb 4, 2024
I noticed this issue from #40852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 600 in the URL doesn't seem to do anything and material UI does not use 600 any way. Remove it from the recommended CDN URL.
material-ui/packages/mui-material/src/styles/createTypography.js
Line 21 in fb2cb7f