[material-ui][Select] Add missing root class #44928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
1 task
Netlify deploy previewhttps://deploy-preview-44928--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
… into add-root-class
DiegoAndai
approved these changes
Jan 3, 2025
2 tasks
|
Have you checked #29593? Did we decided to change so people can specifically customize the Select component? What was the motivation for the change? Is it consistency? Maybe we just needed to update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs says .MuiSelect-root is applied to root component but it's not applied to any element . This PR adds root class to root component