[DataGrid] Reduce dev checks #14416
[DataGrid] Reduce dev checks #14416
Conversation
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-14416--material-ui-x.netlify.app/ |
| inputStabilityCheck: 'once', | ||
| identityFunctionCheck: 'once', |
There was a problem hiding this comment.
Looks like these are default values already: https://github.com/reduxjs/reselect/blob/88e7ffd7d46a1aebf866210075c322a0f424bbe1/src/devModeChecks/setGlobalDevModeChecks.ts#L11-L12
No objections to having them set explicitly though 👍🏻
There was a problem hiding this comment.
Didn't saw them, all good then.
There was a problem hiding this comment.
Merging this PR could still make sense – it's explicit and protects us against the default value change in the future.
What do you think?
There was a problem hiding this comment.
I think it's fine, I would expect that reselect doesn't change their defaults without a major. And at most it makes dev mode slower, so not an issue for our users.
Follow-up of #14410 (comment)
Reselect creates a full memoized selector and a ton of allocations on every selector call in v5, I think dev mode will feel too slow in some cases with those changes.