[test] Fix console warnings while executing tests with React 18 #16386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
test
component: data grid
arminmeh
force-pushed
the
avoid-passing-null-ref
branch
from
1e2a914 to
7eed2d3
Compare
|
Deploy preview: https://deploy-preview-16386--material-ui-x.netlify.app/ |
|
It looks like there are other components, which need similar changes. 🤔 |
|
It didn't work, so I took another approach. |
arminmeh
changed the title
null reference as inputRef prop
arminmeh
commented
Jan 29, 2025
| @@ -18,7 +18,7 @@ export type GridFilterInputValueProps< | |||
| applyValue: (value: GridFilterItem) => void; | |||
| // Is any because if typed as GridApiRef a dep cycle occurs. Same happens if ApiContext is used. | |||
| apiRef: RefObject<Api>; | |||
| inputRef?: React.Ref<any>; | |||
| inputRef?: React.Ref<HTMLElement | null>; | |||
| focusElementRef?: React.Ref<any>; | |||
There was a problem hiding this comment.
should I do the same for focusElementRef?
There was a problem hiding this comment.
Tried it, but it requires a bit more changes than just this type, so I left it as any
if it is not super important, I would leave it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning on React 18 that is breaking the tests
https://app.circleci.com/pipelines/github/mui/mui-x/79788/workflows/e0f5c399-0631-4b3e-a933-7581381b7d66
It does not need a cherry pick.
Before merge: