[DataGrid] Refactor: create base MenuList props #16481
Conversation
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-16481--material-ui-x.netlify.app/ |
| autoFocus?: boolean; | ||
| autoFocusItem?: boolean; |
There was a problem hiding this comment.
Should we instead of these have enum for autoFocus to cover both cases?
There was a problem hiding this comment.
I thought about it but I chose to keep the API material compatible instead. I could be convinced to switch it though.
There was a problem hiding this comment.
If that was the general approach so far (to be close to material) then let's leave it. Otherwise, I think that enum is more generic and neutral and more flexible for potential updates
There was a problem hiding this comment.
The approach is mixed, some components are directly compatibles, others are reworked when the material API is too hard to adapt for other design-systems. I'll leave it as it is for now, I might change it once I start implementing bindings for other design-systems.
Part of the design-system agnostic work.
Create base MenuList props. These are directly compatible with material props.