Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Avoid test warning when running on React 18 #16486

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[test] Avoid test warning when running on React 18 #16486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/x-data-grid-premium/src/tests/cellSelection.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('<DataGridPremium /> - Cell selection', () => {
it('should work with the paginated grid', () => {
render(
<TestDataGridSelection
initialState={{ pagination: { paginationModel: { page: 0, pageSize: 3 } } }}
initialState={{ pagination: { paginationModel: { page: 0, pageSize: 3 }, rowCount: 4 } }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
initialState={{ pagination: { paginationModel: { page: 0, pageSize: 3 }, rowCount: 4 } }}
initialState={{ pagination: { paginationModel: { page: 0, pageSize: 3 }, rowCount: 0 } }}

I think that any value helps, it does not have to match. But it is fine even if you leave it like this

rowLength={30}
pagination
pageSizeOptions={[3]}
Expand Down