Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Native Node.js ESM #16603

Merged
merged 15 commits into from
Feb 18, 2025
Merged

[code-infra] Native Node.js ESM #16603

merged 15 commits into from
Feb 18, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 15, 2025

Closes #11016 as per Stackblitz

Rewrite import specifiers for modules that don't have an exports field. The main import is covered by their main field, but nested paths can't be resolved under ESM rules. Since no exports field is provided, we can still access them under their absolute path.

@mui-bot
Copy link

mui-bot commented Feb 15, 2025

Deploy preview: https://deploy-preview-16603--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0c51b3f

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Feb 16, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 17, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 17, 2025
@Janpot Janpot marked this pull request as ready for review February 17, 2025 14:15
@Janpot Janpot changed the title [code-infra] Native Node.js esm [code-infra] Native Node.js ESM Feb 17, 2025
@Janpot Janpot requested a review from LukasTy February 17, 2025 15:44
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this! 🙏

@Janpot Janpot merged commit 3ed991b into mui:master Feb 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts][ESM] Can't import @mui/x-charts under node.js
3 participants