Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Pivoting PoC #9877

Draft
wants to merge 247 commits into
base: master
Choose a base branch
from
Draft

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Aug 1, 2023

WIP

https://deploy-preview-9877--material-ui-x.netlify.app/x/react-data-grid/pivoting/

Related to #214

Todo

  • Filter fields so that they can only be added to one section at a time @KenanYusuf
  • Empty state for when the pivot sections are empty @KenanYusuf
  • Column menu options—what do we do with the options that affect the pivot table?
  • Clean up field sort component—currently reusing the header sort button @KenanYusuf
  • Clean up @KenanYusuf
    • Component names
    • Use css variables instead of theme
    • Translations
    • Remove (most) Material UI imports
    • Remove Menu import
    • Add classes to styled elements
  • Documentation
  • Move the pivoting hook inside of the data grid @cherniavskii
  • Add more tests @cherniavskii
  • Support rows and columns updates in pivot mode @cherniavskii
  • Check if transposing columns into rows makes sense as part of the pivoting feature: [DataGrid] Transpose columns into rows #3285 @cherniavskii

Follow up

  • Performance improvements (slow on 10k rows)
  • Add support for a field being in "Values" multiple times
  • Add support for a field being in "Columns" and "Values" at the same time
  • Add support for a field being in "Rows" and "Values" at the same time

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 1, 2023
@mui-bot
Copy link

mui-bot commented Aug 1, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-9877--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 2ec953f

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 20, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 24, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 24, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Pivoting Related to the data grid pivoting feature new feature New feature or request plan: Premium Impact at least one Premium user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants