Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper tag for storage go #6653

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Proper tag for storage go #6653

merged 2 commits into from
Dec 5, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Dec 5, 2024
@sstanculeanu sstanculeanu self-assigned this Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@sstanculeanu sstanculeanu marked this pull request as ready for review December 5, 2024 10:48
@sstanculeanu
Copy link
Collaborator Author

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@multiversx multiversx deleted a comment from github-actions bot Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4c24359ab89654bee5b184d2506d31cd959165bf
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-110057
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e1b7df8259c19e17b03cb00babd7dac102ffd609
  • Current Branch: proper_tag
  • mx-chain-go Target Branch: rc/spica-patch-mempool
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-110445
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sstanculeanu sstanculeanu merged commit 861b336 into rc/spica-patch-mempool Dec 5, 2024
8 checks passed
@sstanculeanu sstanculeanu deleted the proper_tag branch December 5, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants