Transaction sig verifier #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txcheck/sigcheck.go
Outdated
| ) | ||
|
|
||
| // SigVerifier defines the methods available for a signature verifier | ||
| type SigVerifier interface { |
There was a problem hiding this comment.
not really needed, builders.TxSigVerifier can be used instead
| if tx == nil { | ||
| return ErrNilTransaction | ||
| } | ||
| if len(pk) == 0 { |
There was a problem hiding this comment.
should we add a second check for max len of pk?
There was a problem hiding this comment.
it will fail on verify, so I don't see a need.
sstanculeanu
previously approved these changes
Nov 11, 2022
dragos-rebegea
previously approved these changes
Nov 14, 2022
| @@ -213,7 +213,7 @@ func transactionToNodeTransaction(tx *data.Transaction) (*transaction.Transactio | |||
| }, nil | |||
| } | |||
|
|
|||
| func transactionToUnsignedTx(tx *data.Transaction) *data.Transaction { | |||
| func TransactionToUnsignedTx(tx *data.Transaction) *data.Transaction { | |||
AdoAdoAdo
dismissed stale reviews from dragos-rebegea and sstanculeanu
via
4a11eee
sstanculeanu
approved these changes
Nov 14, 2022
iulianpascalau
approved these changes
Nov 14, 2022
dragos-rebegea
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.