feat!: replace Mux player w/ Media Chrome + media #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
force-pushed
the
media-chrome-player
branch
from
cb380ff to
fa28996
Compare
luwes
force-pushed
the
media-chrome-player
branch
from
fa28996 to
28a7ddf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 88.88% 86.01% -2.88%
==========================================
Files 32 36 +4
Lines 2601 2995 +394
Branches 362 387 +25
==========================================
+ Hits 2312 2576 +264
- Misses 286 416 +130
Partials 3 3 ☔ View full report in Codecov by Sentry. |
luwes
changed the title
luwes
force-pushed
the
media-chrome-player
branch
from
12b33f9 to
f428efd
Compare
luwes
force-pushed
the
media-chrome-player
branch
from
d4b0653 to
b7ff54c
Compare
mmcc
reviewed
Nov 28, 2024
luwes
commented
Dec 13, 2024
|
|
||
| export type VideoProps<TPlaybackId = string | undefined> = TPlaybackId extends string | ||
| ? Omit<Partial<MuxVideoProps> & PlayerProps, 'src' | 'poster'> & SuperVideoProps & { playbackId?: TPlaybackId } | ||
| : Omit<NativeVideoProps & PlayerProps, 'src' | 'poster'> & SuperVideoProps & { playbackId?: undefined }; |
There was a problem hiding this comment.
this makes it so that when a playbackId is inferred from the src the types adapt to MuxVideoProps, otherwise restricted to native video props. didn't know this was possible since a few days ago, did take some time to figure it out but it's so good!
luwes
added a commit
to luwes/elements
that referenced
this pull request
Dec 19, 2024
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Dec 19, 2024
related muxinc/next-video#303 motivation: - we use the React wrapper with custom mux-video element in 2 places (player.style and next-video soon) - open issue asking for support (#910)
luwes
force-pushed
the
media-chrome-player
branch
from
b78f43a to
6791417
Compare
luwes
force-pushed
the
media-chrome-player
branch
from
6791417 to
3990253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Replace the default player, Mux player with Media Chrome + media elements.
fix #292
Warning
Just noting here that users will lose access to the default Mux player theme since it's not easily accessible.
https://next-video-demo-git-fork-luwes-media-chrome-player-mux.vercel.app/
https://next-video-demo-git-fork-luwes-media-chrome-player-mux.vercel.app/custom-theme
An interesting one is again that we use the mux-video custom element instead of MuxVideoReact because we want to support the renditions and audio tracks API. We did the same in Player.style. (See muxinc/elements#910)