fix: add CLI devscript flag #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luwes
commented
Oct 24, 2023
| await createTSFile(path.join(process.cwd(), 'video.d.ts')); | ||
| changes.push([log.add, `Created video.d.ts.`]); | ||
| } | ||
| if (ts) { |
There was a problem hiding this comment.
moved this out of the if (!ts) {} scope which was a bug if using the flag I think
mmcc
approved these changes
Oct 24, 2023
|
@mmcc do you mean if the user chooses "no" or even before the question give more information on what it does? |
|
No I meant just as an instructional bit at the end. If the user said no, should we let them know at the end that it's a step they might want to add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #78