update dbt-core to v1.7.3 #60
Conversation
|
even though dbt-core is now at v1.7.3, some of the adapters can be a bit behind ARG [email protected] |
|
@mwhitaker is there a chance that you can add dbt-databricks as adapter? It is not recommended to use dbt-spark for databricks anymore. |
|
OK, so this is what I have now: ARG [email protected] Since I don't personally have access to databricks, is there a way for you to test? |
|
@mwhitaker I tested it in a private repository and it works there. Can you upgrade to [email protected]? In addition, it would be great to add an additional substitution of environment variable |
as a user input update ghcr instructions
|
I updated the databricks adapter to v.1.7.3 and I added support for a new optional |
|
the optional |
entrypoint.sh
Outdated
| @@ -28,6 +28,10 @@ elif [ -n "${DBT_TOKEN}" ] | |||
| then | |||
| echo trying to use DBT_TOKEN/databricks | |||
| sed -i "s/_token_/${DBT_TOKEN}/g" ./datab.yml | |||
| elif [ -n "${INPUT_HTTP_PATH}" ] | |||
There was a problem hiding this comment.
This seems to be wrong: For Databricks, we need to use both, the token and the http path.
|
I fixed these issues and others I found in my branch. Check out the commits in my branch |
* fix optional parameter INPUT_HTTP_PATH * fix databricks token profiles.yml file * fix INPUT_HTTP_PATH escape slash in sed * check if profiles.yml exist --------- Co-authored-by: Leo Schick <[email protected]>
|
Thank you Leo, I appreciate it. I basically only use this action with BigQuery so I don't have a way to test the other connectors. I added those changes to this branch. Can you do one more check please? |
|
It works fine for me in my branch. Since I guess this is a fast forward merge, will work here, too. There aren't any differences between my and your branch. |
No description provided.