Create directory structure on rename #1058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwouts
requested changes
Apr 14, 2023
| @@ -481,6 +481,7 @@ def rename_file(self, old_path, new_path): | |||
| for old_alt_path, alt_fmt in old_alt_paths: | |||
| new_alt_path = full_path(new_base, alt_fmt) | |||
| if self.exists(old_alt_path): | |||
| os.makedirs(os.path.dirname(new_alt_path), exist_ok=True) | |||
There was a problem hiding this comment.
I think we should create the directory using the contents manager itself, not os.makedirs, because in some cases the underlying contents manager is not based on a file system.
There was a problem hiding this comment.
Hello @mwouts, that's a fair point indeed!
I am not familiar with Jupyter's internals, but I can take a look.
When talking about the "underlying contents manager", are you referring to the FileContentsManager from jupyter_server?
If so, I can see there is a _save_directory method, but it doesn't look recursive to me.
Any pointer?
|
This should be solved by #1082 . Thanks anyway for submitting this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a global configuration like this one:
and moving a notebook stored under
./notebook/my_notebook.ipynbto a newly created./notebook/subdirdirectory (so that the destination would be./notebook/subdir/my_notebook.ipynb) fails whensubdiris not already present under./scripts/.The proposed change makes the process transparent to the user, by lazily creating the necessary "folder tree" in the mirrored destination.
Issue: #1059