Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core_test active_transactions.fork_filter_cleanup fails occasionally #3762

Closed
dsiganos opened this issue Mar 28, 2022 · 0 comments · Fixed by #3775
Closed

core_test active_transactions.fork_filter_cleanup fails occasionally #3762

dsiganos opened this issue Mar 28, 2022 · 0 comments · Fixed by #3775
Labels
unit test Related to a new, changed or fixed unit test

Comments

@dsiganos
Copy link
Contributor

It has failed in github CI here:
https://github.com/nanocurrency/nano-node/runs/5719749168?check_suite_focus=true#step:6:67

And I made fail on my laptop once by running it in a repeat loop and starting a nano build from scratch in parallel.
On my laptop, it appears to fail once every few hundred iterations.

Note: Google Test filter = active_transactions.fork_filter_cleanup
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from active_transactions
[ RUN      ] active_transactions.fork_filter_cleanup
/home/ds/CLionProjects/receivable_renames/nano/core_test/active_transactions.cpp:790: Failure
Value of: node1.network.publish_filter.apply (send_block_bytes.data (), send_block_bytes.size ())
  Actual: true
Expected: false
Trace/breakpoint trap
@dsiganos dsiganos added the unit test Related to a new, changed or fixed unit test label Mar 28, 2022
This was referenced Mar 30, 2022
Closed
Closed
dsiganos added a commit to dsiganos/nano-node that referenced this issue Apr 2, 2022
@dsiganos
Fix for test active_transactions.fork_filter_cleanup
a353f8e 
The publish filter and the ledger cache count are not synchronised and
therefore the last assert needs to be an assert timely.

resolves nanocurrency#3762
@dsiganos dsiganos mentioned this issue Apr 2, 2022
Merged
dsiganos added a commit that referenced this issue Apr 2, 2022
@dsiganos
Fix for test active_transactions.fork_filter_cleanup (#3775)
6397a44 
The publish filter and the ledger cache count are not synchronised and
therefore the last assert needs to be an assert timely.

resolves #3762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for test active_transactions.fork_filter_cleanup dsiganos/nano-node
1 participant
@dsiganos