Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_balance DB table (draft) #1285

Closed
wants to merge 5 commits into from

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Oct 10, 2018

to improve I/O of balance/amount visitors

data.ldb size
Before: 5302931456
After: 5699977216

to improve I/O of balance/amount visitors
@rkeene rkeene added enhancement incomplete This item is incomplete and should not be merged if it is a pull request labels Oct 10, 2018
@rkeene rkeene added this to the V17.0 milestone Oct 10, 2018
@clemahieu
Copy link
Contributor

Can we put the balance in the value of the block table? hash -> [block_data, balance]

Then we don’t need a separate table and it should pack more efficiently.

@SergiySW
Copy link
Contributor Author

make receive_v1, open_v1, change_v1 tables?

@clemahieu
Copy link
Contributor

We could detect the length. If len = [block_data] it needs update. If len = [block_data, balance] no update needed.

@rkeene rkeene modified the milestones: V17.0, V18.0 Nov 13, 2018
@rkeene
Copy link
Contributor

rkeene commented Nov 13, 2018

This will tie into the change to store block confirmation height (#1303), which has been moved to V18.0

@SergiySW
Copy link
Contributor Author

Tied with DB changes in #1303

@SergiySW
Copy link
Contributor Author

@zhyatt

@SergiySW
Copy link
Contributor Author

@zhyatt zhyatt removed this from the V18.0 milestone Jan 1, 2019
@zhyatt zhyatt closed this Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement incomplete This item is incomplete and should not be merged if it is a pull request medium effort remaining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants