Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC Account history filter #1355

Merged
merged 8 commits into from
Mar 15, 2019
Merged

RPC Account history filter #1355

merged 8 commits into from
Mar 15, 2019

Conversation

ctummon
Copy link
Contributor

@ctummon ctummon commented Nov 6, 2018 •
edited by rkeene
Loading

Fixes #1110

@rkeene rkeene requested a review from argakiig November 7, 2018 04:32
@rkeene rkeene added this to the V19.0 milestone Nov 7, 2018
@ctummon
Copy link
Contributor Author

ctummon commented Nov 7, 2018

Need to have a look at those failing tests, probably timing again, seemed ok locally

argakiig
argakiig suggested changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@argakiig argakiig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1110 was looking for account_history
please adjust test accordingly

@ctummon
Copy link
Contributor Author

ctummon commented Nov 7, 2018

Must not have ran the test with those last two lines at all my bad.
I went with creating a new test for "account_history". We should be ok now, unless you want me to refactor the tests a bit, I can spend a bit more time on it another day.

@rkeene rkeene changed the title RPC Account history filter (Issue #1110) RPC Account history filter Dec 27, 2018
@argakiig
Copy link
Contributor

@CathalT can you rebase and check formatting?

@ctummon
Copy link
Contributor Author

ctummon commented Jan 25, 2019

Just gone on holidays for a week, I'll be back Sunday the 3rd of Feb

@ctummon
Add accounts filter to accounts_history rpc call. nanocurrency#1110
db332d5 
Add test for account_history account filter option.

Remove unnecessary return

Add seperate account_history test.
@ctummon ctummon force-pushed the rpc_account_history_filter branch from befc924 to db332d5 Compare February 6, 2019 19:49
@ctummon
Copy link
Contributor Author

ctummon commented Feb 7, 2019

I'm having trouble building after updating to latest, cryptopp is failing to build some assembly files on windows.
Haven't got a chance to sort it out yet and there are a few more issues to sort for this PR to pass...

@ctummon
Copy link
Contributor Author

ctummon commented Feb 17, 2019

@argakiig those latest failures don't look related to my changes? I think we're looking good

[  FAILED  ] wallet.select_account
[  FAILED  ] wallet.seed_work_generation

@wezrule
Copy link
Contributor

wezrule commented Feb 17, 2019 •
edited
Loading

@CathalT yeh those are intermittent failures don't worry. However could you please run clang-format on your files (ci/clang-format-all.sh). You can see the diff near the top of the travis ci output complaining.

This was referenced Mar 13, 2019
Closed
Merged
@guilhermelawless
Copy link
Contributor

@CathalT there's a conflict

@argakiig argakiig merged commit db4ba1f into nanocurrency:master Mar 15, 2019
@ctummon ctummon deleted the rpc_account_history_filter branch June 14, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

Assignees

@ctummon ctummon

@argakiig argakiig

Labels
enhancement
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.

Enhancement Request: add optional account_filter option to account_history RPC
6 participants
@ctummon @argakiig @wezrule @guilhermelawless @zhyatt @rkeene