Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ip_address_hash from std namespace #1499

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Remove ip_address_hash from std namespace #1499

merged 1 commit into from
Jan 3, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Dec 23, 2018

In similar vein to #1460 the ip_address_hash struct and specializations have been removed from polluting the std namespace.

@zhyatt zhyatt added this to the V18.0 milestone Dec 27, 2018
@zhyatt zhyatt requested a review from clemahieu December 27, 2018 16:34
@rkeene rkeene force-pushed the remove_ip_address_hash_from_std_namespace branch from 46eda74 to a2605c0 Compare December 28, 2018 21:32
@rkeene
Copy link
Contributor

rkeene commented Dec 28, 2018

After merging #1504, I force pushed an update to this branch.

@rkeene rkeene requested review from rkeene and removed request for clemahieu December 31, 2018 20:07
@rkeene rkeene assigned rkeene and unassigned clemahieu Dec 31, 2018
@rkeene rkeene added quality improvements This item indicates the need for or supplies changes that improve maintainability incomplete This item is incomplete and should not be merged if it is a pull request labels Jan 2, 2019
rkeene
rkeene approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@rkeene rkeene removed the incomplete This item is incomplete and should not be merged if it is a pull request label Jan 3, 2019
@rkeene rkeene merged commit 37222c2 into nanocurrency:master Jan 3, 2019
@wezrule wezrule deleted the remove_ip_address_hash_from_std_namespace branch January 8, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeene rkeene rkeene approved these changes

Assignees

@wezrule wezrule

@rkeene rkeene

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wezrule @rkeene @clemahieu @zhyatt