Disable voting by default #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess for test_network it should be true |
added 2 commits
December 28, 2018 16:11
…verwrite existing settings but will ensure new nodes do not vote unless users specify. fixes #1369
rkeene
added
enhancement
major
SergiySW
approved these changes
Jan 5, 2019
|
Are there any concerns that "Disable voting by default [#1509]" will reduce decentralization? Will new node operators (merchants, whales, exchanges, etc) know that they need to manually enable voting once they hit .1% voting weight? Worst case, what if a bunch of node operators clean install a new node version at the same time and forget to enable voting (similar to the issues we had with the v17 upgrade)? Would it make more sense to have the default be no voting unless you have .1%+ voting weight? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... unless user action taken. This will not affect a current config, only newly generated ones
fixes #1369