Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve votes cache usage #1678

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Improve votes cache usage #1678

merged 5 commits into from
Feb 1, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Feb 1, 2019

Search block in cache before disk search
Improving i/o for representative nodes

@SergiySW SergiySW added the functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality label Feb 1, 2019
@SergiySW SergiySW added this to the V18.0 milestone Feb 1, 2019
@SergiySW SergiySW self-assigned this Feb 1, 2019
cryptocode
cryptocode approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was wondering if it would be beneficial to add a votes_cache::remove_all (which would take a rollback list), to lock only once instead of lock/unlock in the remove loop. But that keeps the lock longer... so I think this is right.

@SergiySW SergiySW merged commit f716f82 into nanocurrency:master Feb 1, 2019
argakiig added a commit that referenced this pull request Feb 1, 2019
@argakiig
Revert " Improve votes cache usage (#1678)"
d620b2f 
This reverts commit f716f82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SergiySW @wezrule @cryptocode