Fix reported by TSAN issues #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef4e83b.
SergiySW
added
the
incomplete
SergiySW
force-pushed
the
fix/tsan_conflicts_reprioritize
branch
from
38bc747 to
168f4fe
Compare
SergiySW
force-pushed
the
fix/tsan_conflicts_reprioritize
branch
from
eda5914 to
e3e0ef5
Compare
SergiySW
force-pushed
the
fix/tsan_conflicts_reprioritize
branch
2 times, most recently
from
41af97a to
0bd6dcc
Compare
wezrule
approved these changes
Feb 7, 2019
SergiySW
force-pushed
the
fix/tsan_conflicts_reprioritize
branch
from
a7504f3 to
48fbde7
Compare
|
@wezrule could we comment out batch_point_buffer without issues? |
|
Yes I think so as we don't run their tests right? Could add it to tsanblacklist file, I noticed we have an asan_blacklist file with ed25519 files in but don't seem to use it. |
|
@SergiySW yes it should be fine for our code, will only be a problem if running their tests. But how do we make sure this change doesn't get lost in future upgrades? |
|
Future upgrades of ed25519-donna? It's not upgraded for 3.5 years unfortunantely |
|
oh ok, should be fine then 👍 |
SergiySW
force-pushed
the
fix/tsan_conflicts_reprioritize
branch
from
b7e6177 to
c435e1d
Compare
|
Squash #1739 |
|
Closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Ubuntu 18.04. Clang 6.0, Boost 1.69