Make the sideband open block start at a height of 1 #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergiySW
reviewed
Feb 17, 2019
SergiySW
approved these changes
Feb 17, 2019
SergiySW
added a commit
to SergiySW/raiblocks
that referenced
this pull request
Feb 17, 2019
SergiySW
added a commit
that referenced
this pull request
Feb 17, 2019
* Update CLI --debug_validate_blocks to validate sideband data * Update for #1737 changes * Remove unnecessary timestamp numeric limit check
argakiig
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Open block now starts at height 1 for sideband data * Remove incorrectly modified clang-format file * Change start height of local variable to be 1 instead of addition later
argakiig
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Update CLI --debug_validate_blocks to validate sideband data * Update for #1737 changes * Remove unnecessary timestamp numeric limit check
zhyatt
added
the
functionality quality improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account block count + sideband block height now match at the head
Sideband/confirmation height now start at 0 to indicate that they are uninitialized