Initialize peer_information members #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure Line 56 in 0031cd0 I used in-class member initializers here as there are multiple constructors so saves some duplication in the source file (as well as reducing line count). |
|
I'll move probable_rep_account to in-class since rep_weight is done there (which I assumed had the same issue, didn't catch that some initialization was done in ctor and some in-class now...) |
wezrule
approved these changes
Feb 18, 2019
argakiig
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Initialize peer_information members * Initialize probable_rep_account in-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rep_weight / probable_rep_account had random values.