Respond to keepalive messages within a TCP socket #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
approved these changes
Feb 18, 2019
argakiig
added
the
functionality quality improvements
wezrule
reviewed
Feb 18, 2019
| std::unique_ptr<nano::keepalive> request (new nano::keepalive (error, stream, header_a)); | ||
| if (!error) | ||
| { | ||
| add_request (std::unique_ptr<nano::message> (request.release ())); |
There was a problem hiding this comment.
can't this just be: add_request (std::move (request)); ?
There was a problem hiding this comment.
Yes, a lot of these need to be fixed to use c++13 semantics.
SergiySW
reviewed
Feb 18, 2019
| }); | ||
|
|
||
| auto output (keepalive.to_bytes ()); | ||
| bool done (false); |
There was a problem hiding this comment.
Probably should be atomic ?
SergiySW
reviewed
Feb 18, 2019
| { | ||
| BOOST_LOG (connection->node->log) << boost::str (boost::format ("Keepalive req sent to %1%") % connection->socket->remote_endpoint ()); | ||
| } | ||
| connection->socket->async_write (bytes, [connection = connection](boost::system::error_code const & ec, size_t size_a) { |
There was a problem hiding this comment.
connection = connection (?)
There was a problem hiding this comment.
connection is a member variable, so if you want to pass it in without passing this this is the way to do it (and [&var = var] for reference)
cryptocode
approved these changes
Feb 18, 2019
wezrule
approved these changes
Feb 18, 2019
argakiig
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Respond to keepalive messages within a TCP socket so we can determine version in both directions. * Fixing logging copy-pasta from frontier_req body. * Fixing double-counting incoming keepalives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.