Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicitly converted argument #1751

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Remove implicitly converted argument #1751

merged 1 commit into from
Feb 22, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Feb 19, 2019 •
edited
Loading

This was something I spotted when looking at this area of code. false here is being implicitly converted to an int 0 which is passed in to a function which already has a default parameter unsigned chunk_size = 0. So I'm just removing it.

@wezrule wezrule added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Feb 19, 2019
@wezrule wezrule added this to the V19.0 milestone Feb 19, 2019
@wezrule wezrule self-assigned this Feb 19, 2019
@wezrule wezrule requested a review from cryptocode February 19, 2019 18:41
@wezrule wezrule changed the title Remove unnecessary argument Remove implicitly converted argument Feb 19, 2019
@wezrule wezrule merged commit 0355c19 into nanocurrency:master Feb 22, 2019
@wezrule wezrule deleted the remove_implicit_conversion_argument_import_bits branch February 22, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@wezrule wezrule

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wezrule @cryptocode