RPC 100-continue and max request size #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
the
incomplete
cryptocode
force-pushed
the
rpc-expect-100
branch
from
1d4b7db to
8d17714
Compare
cryptocode
force-pushed
the
rpc-expect-100
branch
from
8d17714 to
fdc7e0e
Compare
cryptocode
removed
the
incomplete
argakiig
approved these changes
Mar 14, 2019
SergiySW
approved these changes
Mar 14, 2019
zhyatt
added
the
documentation
zhyatt
removed
the
documentation
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1671
We've had reports of RPC requests sometimes taking 1 second before being handled. Some clients, such as curl (and Python wrappers), sends an
Expect: 100-continueheader for large requests (per rfc7231). These clients typically wait one second for the header response before sending the body (a workaround in curl is to use -H Expect:)The PR also adds the ability to restrict request body sizes via
config.json. The proposed default limit is 32MB (this must be large enough for services - opinions welcome)