Websocket support #1840
Merged
Websocket support #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
enhancement
incomplete
cryptocode
removed
the
incomplete
argakiig
approved these changes
Mar 18, 2019
clemahieu
reviewed
Mar 22, 2019
…tartup logging and optimize for likely errocode path
clemahieu
approved these changes
Mar 23, 2019
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
* Websocket support * Fix locking, add bind address to config, alwayts pop front message, startup logging and optimize for likely errocode path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for notifications via Websockets. This offers a more efficient callback mechanism for block confirmations, and allows for multiple listeners. As it's topic-based, filtering and additional events can be added in the future. Proper JSON is returned (the http callback returns stringified blocks). Comments on message formatting are most welcome. Note that the http callback is still supported.
Preliminary docs: https://github.com/cryptocode/notes/wiki/Websocket-support
Sample nodejs client: https://github.com/cryptocode/nano-websocket-sample-nodejs