Remove ed25519 and lib library circular dependency #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
cryptocode
approved these changes
Mar 27, 2019
clemahieu
approved these changes
Mar 27, 2019
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We declare our own custom
ed25519functions in nano/lib/interface.cpp which theed25519library is dependent on, however we also useed25519functions inside theliblibrary, so to resolve this circular dependency I have created a new librarycrypto_libfor lack of a better name which extracts the customed25519function definitions and also a class it is dependent onrandom_pool.