Refactor preparation for moving RPC out of process #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
cryptocode
approved these changes
Mar 27, 2019
|
Thanks :) |
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
* Move things around preparing for RPC out of process * Add rpc_test executable for testing rpc commands * Add rpc_test to ci * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move RPC classes to a new subfolder nano/rpc and also create a few different files to hold the related clases in. It currently depends on the
nodelibrary (and vice versa) but this dependency will be removed in the main RPC task. Also moved the rpc tests to their own executable.Extracted a few other things like thread_runner, logging, ipc_client/transport etc.. to the lib library to make them accessible to other libraries which won't have access to the
nodelibrary (e.g the new RPC server process).