Update confirmation height in another thread #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
wezrule
changed the title
zhyatt
requested review from
argakiig,
SergiySW and
cryptocode
and removed request for
SergiySW
cryptocode
reviewed
Apr 2, 2019
argakiig
approved these changes
Apr 4, 2019
SergiySW
reviewed
Apr 5, 2019
cryptocode
reviewed
Apr 6, 2019
wezrule
force-pushed
the
confirmation_height_processor
branch
from
6195e41 to
dda6ca3
Compare
…ng to see what hash is currently ungoing confirmation height processing
…t the tested accounts auto receiving the blocks
…he RPC request to reduce timing issues with ci.
wezrule
force-pushed
the
confirmation_height_processor
branch
from
de4a441 to
c2b2068
Compare
SergiySW
reviewed
Apr 19, 2019
cryptocode
suggested changes
Apr 20, 2019
cryptocode
approved these changes
Apr 20, 2019
clemahieu
approved these changes
Apr 24, 2019
|
@wezrule Can you help review the stats RPC documentation and help suggest updates? https://docs.nano.org/commands/rpc-protocol/#stats and https://docs.nano.org/running-a-node/troubleshooting/#statistics-from-rpc. Looks like we may want to combine and possibly expand some pieces, not sure. The other RPC and CLI command in this ticket look good in the docs. Another related stats ticket: #1955 |
|
@zhatt it was quite out of date, have added the missing stats. |
zhyatt
removed
the
documentation
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the confirmation height is updated on io threads, and if it touches a long chain it can take a very long time (30 minutes) because it can update pretty much the whole ledger. A different approach is now taken. When a block being confirmed, we go down to the lowest block in the chain which has not been confirmed and store each receive block along the way. We now start at the lowest (before it would have been the highest) receive and iterate to the source accounts until we get to a chain where there are no more unconfirmed receives, storing this in a collection of pending writes , working our way from the bottom upwards.
API changes:
RPC stats -> counters.
confirmed_block_countshows the number of blocks confirmed during node start-upRPC stats -> objects.
confirmation_height_processor->receive_source_pairs. The current number of receive-source pairs that still await iterative confirmation for the current block being confirmed.pending_confirmation_height->pending- The number of top level block hashes in the queue awaiting confirmationRPC
{"action":"confirmation_height_currently_processing"}this will return the hash if any which is currently being processed. To be marked as unstable/debug.CLI:
--debug_cemented_block_countiterates over all account chains and sums up the confirmation heights (can take a little bit). For the first time the node is launched this will be 1 more than that in stats -> counters due to the implicitly confirmed genesis block.