-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets - filtering options #1907
Websockets - filtering options #1907
Conversation
#1906 is merged so this one will need a rebase @guilhermelawless |
Could we get a test for confirmations being filtered / not filtered for both query options? I'm adding the documentation tag so we remember to update https://github.com/nanocurrency/nano-node/wiki/WebSockets once merged. |
…ge.to_string const
Some tests were failing due to the destination being in Other tests were incomplete or some things untested due to not using a true async read on the socket client test. Everything should be ok now. |
…dcasted, but with any filtering options they're not supported (always filtered)
@guilhermelawless Thanks! The Websocket Wiki page needs an update, feel free to attach markup here. |
@cryptocode |
Docs merged into the Websockets wiki page |
This adds per-subscription filtering options via an extra field in a subscribe action:
Filtering happens after the message is built and is sent for broadcasting, with a bunch of O(1) checks for existance of accounts. We would have to change the dynamics of the websocket server quite a bit to handle it differently. Open to suggestions as usually or just pickup from this PR and improve!
Can add something to
core_test
if this seems ok.Related: #1901