Websockets - subscribe to votes #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
documentation
clemahieu
approved these changes
Apr 18, 2019
| { | ||
| // Do not insert the given raw data to keep old prefix support | ||
| representatives.insert (result_l.to_account ()); | ||
| } |
There was a problem hiding this comment.
Can we log if the account doesn't decode correctly? It seems like on a type-o someone could be confused as to why it's not working.
There was a problem hiding this comment.
Yeah makes more sense to log, thanks! Also logging if the resulting filter is empty.
Note to change documentation which warned about this.
|
So, for now, have only Updated documentation WebSockets.zip |
|
Merged @guilhermelawless's markup to https://github.com/nanocurrency/nano-node/wiki/WebSockets |
zhyatt
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1901 .
{ "topic": "vote", "time": "1554995525343", "message": { "account": "xrb_1n5aisgwmq1oibg8c7aerrubboccp3mfcjgm8jaas1fwhxmcndaf4jrt75fy", "signature": "1950700796914893705657789944906107642480343124305202910152471520450456881722545967829502369630995363643731706156278026749554294222131169148120786048025353", "sequence": "855471574", "blocks": [ "6FB9DE5D7908DEB8A2EA391AEA95041587CBF3420EF8A606F1489FECEE75C869" ] } }Added the ability to filter by representative as well, very similarly to the other filtering options. I think this one has no performance penalties, just a O(1) search in an unordered_set.
A good filter would also be
rebroadcasting_onlyor a minimum weight. What do you think?