Replace xxHash with blake2b #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
suggested changes
Apr 25, 2019
wezrule
reviewed
Apr 25, 2019
clemahieu
reviewed
Apr 25, 2019
| auto result (XXH64_digest (state)); | ||
| XXH64_freeState (state); | ||
| blake2b_state state; | ||
| blake2b_init (&state, sizeof (result)); |
There was a problem hiding this comment.
Let's use the blake2b_init_key initializer which does the key-initialization for us.
There was a problem hiding this comment.
It's much slower than extra blake2b_update, like 1.5-2 times
cryptocode
approved these changes
Apr 25, 2019
|
Can be modified with random_constants from #1928 |
|
I did an ASAN run on core_test/live and it didn't hit any of CryptoPP uninitialized global warnings, so LGTM. |
wezrule
approved these changes
Apr 27, 2019
cryptocode
approved these changes
Apr 30, 2019
cryptocode
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.