Allow long running read transactions to be broken up #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
functionality quality improvements
cryptocode
approved these changes
May 3, 2019
argakiig
pushed a commit
that referenced
this pull request
May 6, 2019
* Extend read/write transaction functionality * Formatting * Add changes to gui * Add missing override specifier * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables long running read transactions to be broken up and reuse the same transaction object instead of creating a new one each time periodically which is more efficient as per the official documentation. This will help with some of the forthcoming transaction breakup tasks.
As read/write now return different concrete objects (to make use of RAII for automatic cleanup) they can no longer be specified by using a
boolargument (which is a good thing imo). This is what most of the changes done are for.It is currently possible to pass a read only transaction object to something that expects a write transaction, this is only apparent at run-time. This can now be made a compile-time constraint by specifying a
write_transaction. Widespread changes can be made to accommodate this but were not done here as to make only necessary changes during the RC.