Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print info about network and path, when running daemon #1953

Merged
merged 6 commits into from
Jun 6, 2019
Merged

Print info about network and path, when running daemon #1953

merged 6 commits into from
Jun 6, 2019

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented May 4, 2019 •
edited
Loading

After multiple human mistakes, this is my proposal.

In CLI:

./nano_node --daemon --network test
Network: test, version: 20.0
Path: /home/USER/NanoTest

In log:

[2019-05-04 10:51:12.104364]: Active network: test

wezrule added a commit to wezrule/raiblocks that referenced this pull request May 6, 2019
@wezrule
Simplify get_current_network_as_string stealing from nanocurrency#1953
940d51e
wezrule added a commit that referenced this pull request May 6, 2019
@wezrule
Pass command line arguments (network/data_path) to nano_rpc child pro…
3ea9c70 
…cess (#1957)

* Pass command line args to nano_rpc

* Remove unused network_params

* Formatting

* Simplify get_current_network_as_string stealing from #1953
argakiig pushed a commit that referenced this pull request May 6, 2019
@wezrule
Pass command line arguments (network/data_path) to nano_rpc child pro…
f656ac2 
…cess (#1957)

* Pass command line args to nano_rpc

* Remove unused network_params

* Formatting

* Simplify get_current_network_as_string stealing from #1953
@zhyatt zhyatt requested a review from wezrule May 23, 2019 14:38
@zhyatt zhyatt added the documentation This item indicates the need for or supplies updated or expanded documentation label May 30, 2019
@zhyatt zhyatt added this to the V19.0 milestone May 30, 2019
wezrule
wezrule reviewed May 30, 2019
View reviewed changes
nano/qt/qt.cpp
std::string network = "Live";
if (wallet.node.network_params.network.is_beta_network ())
std::string network = wallet.node.network_params.network.get_current_network_as_string ();
if (!network.empty ())
Copy link
Contributor

@wezrule wezrule May 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably unnecessary (overly defensive) as network will always be populated, but it's fine as well.

@wezrule wezrule merged commit 940f4ae into nanocurrency:master Jun 6, 2019
argakiig pushed a commit that referenced this pull request Jun 11, 2019
Print info about network and path, when running daemon (#1953)
52991cd 
* Print info about network and path, when running daemon

* Fix wallet build

* Use method introduced in #1957

* Fix wallet build again

* log order
@guilhermelawless guilhermelawless deleted the daemon-cout branch June 17, 2019 15:50
@zhyatt zhyatt added enhancement and removed documentation This item indicates the need for or supplies updated or expanded documentation labels Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
enhancement
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @wezrule @zhyatt