Move common UDP/TCP channels functions to transport #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SergiySW
commented
May 9, 2019
SergiySW
commented
- common tcp/udp channels functions moved to transport.hpp
- added last_packet_sent time_point
- RPC peers modified to return channel type with option "peer_details"
- common tcp/udp channels functions moved to transport.hpp - added last_packet_sent time_point - RPC peers modified to return channel type with option "peer_details"
|
Breaking up #1962 |
SergiySW
changed the title
clemahieu
approved these changes
May 10, 2019
nano/node/transport/transport.cpp
Outdated
| { | ||
| return nano::tcp_endpoint (endpoint_a.address (), endpoint_a.port ()); | ||
| } | ||
|
|
||
| void nano::transport::channel::send_buffer (std::shared_ptr<std::vector<uint8_t>> buffer_a, nano::stat::detail detail_a, std::function<void(boost::system::error_code const &, size_t)> const & callback_a) const | ||
| { | ||
| send_buffer_raw (boost::asio::buffer (buffer_a->data (), buffer_a->size ()), callback (buffer_a, detail_a, callback_a)); |
There was a problem hiding this comment.
I think here would be a good place to call set_last_packet_sent and then all then we don't need to do that at all the send_buffer call sites and we can't accidentally forget it in the future.
There was a problem hiding this comment.
This will remove const from send, send_buffer, send_buffer_raw
But make things easier
cryptocode
approved these changes
May 13, 2019
SergiySW
added a commit
to SergiySW/raiblocks
that referenced
this pull request
May 15, 2019
Error in PR nanocurrency#1971
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.