Prioritize frontiers for background confirmation #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
functionality quality improvements
SergiySW
reviewed
May 15, 2019
SergiySW
reviewed
May 27, 2019
SergiySW
reviewed
May 27, 2019
SergiySW
reviewed
May 27, 2019
SergiySW
approved these changes
May 30, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Prioritize frontiers for background confirmation * Remove priority_cemented_* to priority_cementable_* * When active root transactions are low override the next_frontier_check * Reduce io * Formatting * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the confirmation height for frontiers in the background (in the request loop) takes too long to get the cemented block count close to the total block count currently. The accounts are just searched from lowest account number onwards, which has now been improved by using the request loop wait period to scan through as many accounts as possible and prioritize the ones which have the most uncemented blocks. These are then voted on, which allows more efficient voting traffic as the larger unconfirmed accounts are more likely to confirm other accounts.
Some other parameters have also been modified to make confirming blocks more aggressive when the active root count is low.