Fix TSAN error with test confirmation_height.conflict_rollback_cemented #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
unit test
SergiySW
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::stringstreamused to redirectcerris not thread safe as it can be modifed when logging is done in the background while we are trying to read from it. I've wrapped it in a boost sink which gives exclusive access now with a mutex, this is only used in tests. I also don't think it is thread-safe to add a sink on the fly so am doing this at the start of the test as well.Add more blocks to use in
rpc.confirmation_height_currently_processingto prevent it failing when run under ASAN.