Add threshold optional to RPC unopened and ledger #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
rpc nonbreaking change
documentation
|
Wondering if we should incorporate the pending balance into this filter's consideration when pending balances are requested. The decision tree would look a bit different then. |
|
After discussions with @guilhermelawless, we ended up deciding this PR should be updated to include @renesq's idea |
guilhermelawless
force-pushed
the
rpc/heavy-threshold
branch
from
146ced1 to
8721c81
Compare
wezrule
approved these changes
Jun 3, 2019
guilhermelawless
pushed a commit
to guilhermelawless/nano-docs
that referenced
this pull request
Jun 3, 2019
zhyatt
pushed a commit
to nanocurrency/nano-docs
that referenced
this pull request
Jun 4, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Add threshold optional to RPC unopened and ledger * For RPC ledger, if pending is requested, then threshold applies to balance+pending
zhyatt
removed
the
documentation
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPCs ledger and unopened
Suggested by @renesq , this is an alternative to pagination for lower powered nodes who want information about the ledger (and helps the scalability of this command in the future).
In both cases, the optional
countis still honored.Documentation update needed.