active_transaction.roots bounding by config instead of confirmation rate #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
added
the
documentation
only flush if roots.size() >= active_elections_size acltive_elections_size added to config and re-factor simplified should_flush update config v17 and upgrade path tests
added 2 commits
June 2, 2019 20:33
clear when it would fall out of scope prior
wezrule
reviewed
Jun 3, 2019
zhyatt
added
the
functionality quality improvements
wezrule
approved these changes
Jun 6, 2019
SergiySW
approved these changes
Jun 6, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
…ate (#2051) * remove transaction counter and associated tests only flush if roots.size() >= active_elections_size acltive_elections_size added to config and re-factor simplified should_flush update config v17 and upgrade path tests * move inactive to active_transactions clear when it would fall out of scope prior * update tests and set default to 8k * Revert "move inactive to active_transactions" This reverts commit b93ae6d. * merge from master cleanup
zhyatt
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove transaction counter and associated tests
only flush if roots.size() >= active_elections_size
active_elections_size added to config and re-factor simplified should_flush
update config v17 and upgrade path tests
ensure active_elections_size is 250 or greater