Websocket/extended confirmation support #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyatt
added
the
documentation
SergiySW
reviewed
Jun 7, 2019
SergiySW
approved these changes
Jun 8, 2019
wezrule
approved these changes
Jun 9, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* WS: Add support for confirmation without block contents * Confirmation type filtering * Remove debugging code * Better comments * Use if/else
zhyatt
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #2058.
Includes stopped-election subscription, and option to get confirmations without full block info.
A documentation PR remains.
This could probably use some more unit tests. If we want this in quickly for testing confirmation callbacks, I could add those to a separate PR, otherwise I'll mark as incomplete.