Use correct index when iterating prioritized frontiers #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing higher counts when max frontiers is reached
wezrule
added
bug
quality improvements
SergiySW
reviewed
Jun 9, 2019
SergiySW
reviewed
Jun 9, 2019
wezrule
force-pushed
the
confirm_frontiers_iterate_order
branch
from
619ef5b to
6dbc011
Compare
SergiySW
approved these changes
Jun 10, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Use correct index when iterating multi-index container * Overwrite frontiers with low uncemented blocks with frontiers containing higher counts when max frontiers is reached * Review comments * Re-add removed stopped check in request loop * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053 changed the collection used for prioritizing frontiers to be a
boost::multi_indexcontainer, but was iterating over the default (wrong) index afterwards. There's not really a way to test this as the active roots has no "insertion" order, I do however check that therootsdoes contain the expected frontier hashes though.I've also modified the
prioritize_frontiers_for_confirmationso that instead of stopping iterating when the container is full, it continues and replaces the frontier with the lowest amount of uncemented blocks with higher ones.