Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More aggressive setting confirmation height of frontiers during low tps #2126

Merged
merged 1 commit into from
Jul 4, 2019
Merged

More aggressive setting confirmation height of frontiers during low tps #2126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions nano/node/active_transactions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ void nano::active_transactions::confirm_frontiers (nano::transaction const & tra
auto check_time_exceeded = std::chrono::steady_clock::now () >= next_frontier_check;
lk.unlock ();
auto low_active_elections = roots_size < max_elections;
if (roots_size <= node.config.active_elections_size && (check_time_exceeded || (!is_test_network && low_active_elections)))
// To minimise dropping real-time transactions, set the maximum number of elections
// for cementing frontiers to half the total active election maximum.
const auto max_active = node.config.active_elections_size / 2;
if (roots_size <= max_active && (check_time_exceeded || (!is_test_network && low_active_elections)))
{
// When the number of active elections is low increase max number of elections for setting confirmation height.
if (max_broadcast_queue > roots_size + max_elections)
if (max_active > roots_size + max_elections)
{
max_elections = max_broadcast_queue - roots_size;
max_elections = max_active - roots_size;
}

// Spend time prioritizing accounts to reduce voting traffic
Expand Down