Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max_broadcast_queue #2137

Closed
wants to merge 3 commits into from
Closed

Increase max_broadcast_queue #2137

wants to merge 3 commits into from

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Jul 7, 2019

to 2000

@SergiySW SergiySW added this to the V19.0 milestone Jul 7, 2019
@SergiySW SergiySW requested review from wezrule and cryptocode July 7, 2019 18:14
@SergiySW SergiySW self-assigned this Jul 7, 2019
@zhyatt zhyatt requested a review from clemahieu July 8, 2019 15:19
cryptocode
cryptocode approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the following is intensional:

request_loop delay: effectively unchanged

active_transactions::confirm_frontiers' max_elections goes from 250 to 500

In the confirm request loop, this upper limit changes from 7000 to 14000:

if (rep_request->second.size () < max_broadcast_queue * nano::network::confirm_req_hashes_max)

max_broadcast_queue is used as an upper bound a few other places in request_confirm as well.

@zhyatt zhyatt modified the milestones: V19.0, V20.0 Jul 9, 2019
@zhyatt zhyatt removed the request for review from clemahieu July 31, 2019 16:01
@guilhermelawless guilhermelawless mentioned this pull request Sep 9, 2019
Closed
@guilhermelawless guilhermelawless mentioned this pull request Oct 10, 2019
Merged
4 tasks
@zhyatt zhyatt removed this from the V20.0 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
enhancement networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @wezrule @cryptocode @zhyatt