Watch blocks separately in work watcher #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses node alarms to be more accurate in the time between block confirmation + re-working Time is now set after the previous work is complete Removes work_watcher thread
guilhermelawless
added
functionality quality improvements
argakiig
approved these changes
Aug 23, 2019
guilhermelawless
added
the
incomplete
Cancelling current and future blocks works consistently now because all work generation gets put into a queue
SergiySW
approved these changes
Aug 26, 2019
guilhermelawless
removed
the
incomplete
argakiig
approved these changes
Aug 26, 2019
SergiySW
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Update this or #2218 based on which one gets merged first, to use limited active difficulty here.doneAs the watcher previously worked on a loop and
condition.wait_untilit would happen that a block would be re-worked before the default 5 seconds had passed.New version
Passes tests but should be validated on beta.