Fixes account_history RPC to include receive blocks when filtering accounts. #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve blocks were filtered out as it was comparing link hash instead of link as account. Also added test case for receive blocks
cryptocode
approved these changes
Aug 24, 2019
There was a problem hiding this comment.
LGTM. Marking as potentially breaking as some client may depend on old behaviour of receives being filtered (even if it's wrong). Add documentation tag if https://docs.nano.org/commands/rpc-protocol/#account_history needs an update.
guilhermelawless
added
the
documentation
|
Added documentation tag, @Srayman could you add an accompanying PR to nano-docs, with a link to this one? |
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously receive blocks were filtered out as it was comparing link hash instead of link as account.
Also added test case for receive blocks in addition to existing send block test case.